Fix: Prevent projectAlgorithm overwrite in Reflection Widget (#6172)#6174
Open
moksha-hub wants to merge 1 commit intosugarlabs:masterfrom
Open
Fix: Prevent projectAlgorithm overwrite in Reflection Widget (#6172)#6174moksha-hub wants to merge 1 commit intosugarlabs:masterfrom
moksha-hub wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
moksha-hub
force-pushed
the
fix/6172-projectalgorithm-overwrite
branch
from
d5a8d6b to
b4a5cfa
Compare
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
1 similar comment
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
moksha-hub
force-pushed
the
fix/6172-projectalgorithm-overwrite
branch
from
4513edc to
1bb48ab
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
moksha-hub
force-pushed
the
fix/6172-projectalgorithm-overwrite
branch
from
1bb48ab to
bf1a7dd
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
moksha-hub
force-pushed
the
fix/6172-projectalgorithm-overwrite
branch
from
bf1a7dd to
4ad5f7b
Compare
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
parthdagia05
reviewed
Mar 9, 2026
Contributor
parthdagia05
left a comment
parthdagia05
left a comment
There was a problem hiding this comment.
Could you clarify how removing this assignment addresses the race condition between sendMessage() and botReplyDiv()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6172
PR Category